fix: handle parsing deleted, added empty files#37
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves parse-git-diff to correctly handle added or deleted empty files by capturing their paths from the diff header and adjusting the generation logic.
- Extracts source and target paths using a new comparison-line parser
- Updates deleted/new file branches to prefer header paths over change markers or chunk data
- Adds fixtures and snapshot tests for renamed, added, and deleted empty files
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/parse-git-diff.ts | Introduced pasreComparisonInputLine, updated how empty-file paths are captured and handled |
| src/tests/renamed-empty.test.ts | Added snapshot test for renamed-empty fixture |
| src/tests/renamed-empty-file.test.ts | Duplicate test for renamed-empty scenario (potential redundancy) |
| src/tests/deleted-empty-file.test.ts | Added snapshot test for deleted-empty-file scenario |
| src/tests/added-empty-file.test.ts | Added snapshot test for added-empty-file scenario |
| src/fixtures/renamed-empty | Fixture for renamed-empty diff |
| src/fixtures/deleted-empty-file | Fixture for deleted-empty-file diff |
| src/fixtures/added-empty-file | Fixture for added-empty-file diff |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 98.46% 98.55% +0.08%
==========================================
Files 4 4
Lines 196 208 +12
Branches 60 62 +2
==========================================
+ Hits 193 205 +12
Misses 2 2
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #31